RFR: 8263640: hs_err improvement: handle class path longer than O_BUFLEN [v3]

David Holmes dholmes at openjdk.java.net
Tue Jun 29 02:37:07 UTC 2021


On Mon, 28 Jun 2021 22:54:23 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Thanks for your review.
>> I've changed it to st->print_raw_cr() so that st->cr() is not needed.
>> I also removed the "@requires vm.cds" from the test since it is unrelated to cds.
>
> How about doing this? This will make sure the print_raw_cr() path is tested (i.e., when generating hs_err files).
> 
> 
>   if (len == 0) {
>     st->print_raw_cr("<not set>");
>   } else {
>     st->print_raw_cr(path, len);
>   }

Please add a comment why print_raw is used.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4616


More information about the hotspot-runtime-dev mailing list