RFR: 8269416: [JVMCI] capture libjvmci crash data to a file [v3]

[David Holmes]

On Tue, 29 Jun 2021 21:54:30 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> When a fatal error occurs in libgraal, it writes a crash dump to `tty`. Instead, it should be captured in a separate log file that is then referenced in the HotSpot crash summary (just like the hs_err_pid and CI replay compile log files are). This allows libgraal crash data to be more easily submitted along with VM crash reports.
>> 
>> For example:
>> 
>>> java -Dlibgraal.CrashAtIsFatal=true -Dgraal.CrashAt=String.equals -cp bin CountUppercase skjdf
>> #
>> # A fatal error has been detected by the Java Runtime Environment:
>> #
>> #  Internal Error (jvmciRuntime.cpp:909), pid=36298, tid=41219
>> #  fatal error: thread 41219: Fatal error in JVMCI shared library
>> #
>> # JRE version: OpenJDK Runtime Environment GraalVM LIBGRAAL 21.3.0-dev (16.0.2) (build 16.0.2-internal+0-adhoc.dnsimon.labsjdk-ce-16)
>> # Java VM: OpenJDK 64-Bit Server VM GraalVM LIBGRAAL 21.3.0-dev (16.0.2-internal+0-adhoc.dnsimon.labsjdk-ce-16, mixed mode, tiered, jvmci, jvmci compiler, compressed oops, compressed class ptrs, g1 gc, bsd-amd64)
>> # No core dump will be written. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again
>> #
>> # An error report file with more information is saved as:
>> # /Users/dnsimon/graal/graal/compiler/hs_err_pid36298.log
>> #
>> # The JVMCI shared library error data is saved as:
>> # /Users/dnsimon/graal/graal/compiler/hs_err_pid36298_libjvmci.log
>> #
>> # If you would like to submit a bug report, please visit:
>> #   https://bugreport.java.com/bugreport/crash.jsp
>> # The crash happened outside the Java Virtual Machine in native code.
>> # See problematic frame for where to report the bug.
>> #
>
> Doug Simon has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR.

Personally I think JVMCI error reporting can be handled independently of the other VM error reporting flags etc. No need to interact with ErrorFileToStdOut/Err as this is not the error file that flag refers to.

I will take a look at the changes in more detail.

Thanks,
David

-------------

PR: https://git.openjdk.java.net/jdk/pull/4620