RFR: 8261479: CDS runtime code should check exceptions [v2]

[Calvin Cheung]

On Mon, 22 Mar 2021 22:20:38 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> I think this should also be be changed to a `CHECK`:
> 
> ```
> void MetaspaceShared::post_initialize(TRAPS) {
>   if (UseSharedSpaces) {
>     int size = FileMapInfo::get_number_of_shared_paths();
>     if (size > 0) {
>       SystemDictionaryShared::allocate_shared_data_arrays(size, THREAD); <<<<
> ```

It was already changed to a `CHECK` in the webrev:
219     int size = FileMapInfo::get_number_of_shared_paths();
220     if (size > 0) {
221       SystemDictionaryShared::allocate_shared_data_arrays(size, CHECK);

> src/hotspot/share/memory/metaspaceShared.cpp line 714:
> 
>> 712:     if (use_full_module_graph()) {
>> 713:       HeapShared::reset_archived_object_states(THREAD);
>> 714:       if (HAS_PENDING_EXCEPTION) {
> 
> I think this is not necessary. If an exception is thrown, it will be be printed by `MetaspaceShared::preload_and_dump()`

Do you mean I should keep the original code as follows?

 712   if (use_full_module_graph()) {
 713     HeapShared::reset_archived_object_states(CHECK);
 714   }

-------------

PR: https://git.openjdk.java.net/jdk/pull/3097