RFR: 8264142: Remove TRAPS/THREAD parameters for verifier related functions [v3]

[Harold Seigel]

On Fri, 26 Mar 2021 04:51:31 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Harold Seigel has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comment changes
>
> src/hotspot/share/classfile/verifier.cpp line 138:
> 
>> 136: // Prints the end-verification message to the appropriate output.
>> 137: void Verifier::log_end_verification(outputStream* st, const char* klassName, Symbol* exception_name, oop pending_exception) {
>> 138:    Thread* THREAD = Thread::current();
> 
> This is not needed.

removed. Thanks for pointing that out.

> src/hotspot/share/classfile/verifier.cpp line 142:
> 
>> 140:   if (pending_exception != NULL) {
>> 141:     st->print("Verification for %s has", klassName);
>> 142:     oop message = java_lang_Throwable::message(PENDING_EXCEPTION);
> 
> This should be pending_exception

fixed

> src/hotspot/share/classfile/verifier.cpp line 198:
> 
>> 196:   log_info(class, init)("Start class verification for: %s", klass->external_name());
>> 197:   if (klass->major_version() >= STACKMAP_ATTRIBUTE_MAJOR_VERSION) {
>> 198:     ClassVerifier split_verifier(THREAD->as_Java_thread(), klass);
> 
> You already have the "jt" JavaThread for this.

Fixed.

> src/hotspot/share/classfile/verifier.cpp line 199:
> 
>> 197:   if (klass->major_version() >= STACKMAP_ATTRIBUTE_MAJOR_VERSION) {
>> 198:     ClassVerifier split_verifier(THREAD->as_Java_thread(), klass);
>> 199:     split_verifier.verify_class(THREAD);
> 
> Can you add the following comment before verify_class please
> 
> // We don't use CHECK here, or on inference_verify below, so that we can log any exception.
> 
> Thanks

done, thanks for suggesting this.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3194