RFR: 8264142: Remove TRAPS/THREAD parameters for verifier related functions [v4]

[Harold Seigel]

On Fri, 26 Mar 2021 05:04:55 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Harold Seigel has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address dholmes's comments
>
> src/hotspot/share/classfile/verifier.cpp line 695:
> 
>> 693:   ConstantPool* cp = _klass->constants();
>> 694:   Symbol* const method_sig = cp->symbol_at(sig_index);
>> 695:   translate_signature(method_sig, sig_verif_types, CHECK_VERIFY(this));
> 
> CHECK_VERIFY is not directly related to exceptions. Are there really no verification errors possible from all of these calls where CHECK_VERIFY has been removed?

The calls where CHECK_VERIFY's were removed are to functions that deal with signatures.  These methods do not check for errors because the signatures have already been verified by classFileParser.cpp in functions such as verify_legal_method_signature() and verify_legal_field_signature().

-------------

PR: https://git.openjdk.java.net/jdk/pull/3194