RFR: 8266496: WBIsKlassAliveClosure.do_klass() fails for hidden classes

[David Holmes]

On Wed, 5 May 2021 12:49:20 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

> Please review this small fix for JDK-8266496.  The fix changes WBIsKlassAliveClosure.do_klass() so that when it compares the specified name with the name of a hidden class, it truncates the hidden class's name at the first '+' character before doing the comparison.  This should work except in the rare case when the pre-mangled hidden class name contains a '+' character.
> 
> The fix was tested with Mach5 tiers 1 and 2 on Linux, Mac OS, and Windows, and tiers 3-5 on Linux x64.
> 
> Thanks, Harold

Hi Harold,

Fix seems fine - certainly good enough for whitebox purposes.

Does the test need to generate the classfile? can't you just define a class in the same source file and then read the class file from disk? Whenever I see asm being used I wonder what it is about the class that prevented it being written in Java.

Thanks,
David

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3882