RFR: 8266496: WBIsKlassAliveClosure.do_klass() fails for hidden classes

Harold Seigel hseigel at openjdk.java.net
Wed May 5 13:43:50 UTC 2021


On Wed, 5 May 2021 12:49:20 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

> Please review this small fix for JDK-8266496.  The fix changes WBIsKlassAliveClosure.do_klass() so that when it compares the specified name with the name of a hidden class, it truncates the hidden class's name at the first '+' character before doing the comparison.  This should work except in the rare case when the pre-mangled hidden class name contains a '+' character.
> 
> The fix was tested with Mach5 tiers 1 and 2 on Linux, Mac OS, and Windows, and tiers 3-5 on Linux x64.
> 
> Thanks, Harold

Hi David,
Thanks for reviewing this.  The test doesn't need to use asm.  It could load the class from disk as you suggested, or even use InMemoryJavaCompiler.  Please let me know if I should change the test.

Thanks, Harold

-------------

PR: https://git.openjdk.java.net/jdk/pull/3882


More information about the hotspot-runtime-dev mailing list