RFR: JDK-8266536: Provide a variant of os::iso8601_time which works with arbitrary timestamps
Thomas Stuefe
stuefe at openjdk.java.net
Thu May 6 04:43:13 UTC 2021
On Thu, 6 May 2021 04:34:28 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> src/java.desktop/share/native/libharfbuzz/hb-ot-shape-complex-use-machine.hh line 378:
>>
>>> 376: {
>>> 377: machine_index_t (const Iter& it) : it (it) {}
>>> 378: machine_index_t (const machine_index_t& o) : hb_iter_with_fallback_t<machine_index_t<Iter>, typename Iter::item_t>(o), it (o.it) {}
>>
>> is it relevant?
>> I feel it belongs to a separated issue.
>
> Sorry, forgot to mention. Unrelated harfbuzz build fix for gcc 8 and earlier. Will remove before the final push.
> The API change looks good to me. I understand that this is prerequisite of your logdecoration change. make sense.
>
> I don't understand your change in harfbuzz header.
Thanks for your review, Xin.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3869
More information about the hotspot-runtime-dev
mailing list