RFR: 8262952: [macos_aarch64] os::commit_memory failure [v2]
Gerard Ziemski
gziemski at openjdk.java.net
Wed May 12 14:49:12 UTC 2021
On Wed, 12 May 2021 08:10:10 GMT, Andrew Haley <aph at openjdk.org> wrote:
>> Gerard Ziemski has updated the pull request incrementally with one additional commit since the last revision:
>>
>> do not expose memory with exec priviledges unless explicitly asked for, fix the test intead to ask for exececutable memory as needed
>
> test/hotspot/gtest/runtime/test_os.cpp line 371:
>
>> 369: for (int stripe = 0; stripe < num_stripes; stripe++) {
>> 370: address q = p + (stripe * stripe_len);
>> 371: q = (address)os::attempt_reserve_memory_at((char*)q, stripe_len, true);
>
> A comment here would hurt no one.
I used the existing "executable" flag here, which already had a comment explaining it.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3865
More information about the hotspot-runtime-dev
mailing list