RFR: 8262952: [macos_aarch64] os::commit_memory failure [v2]

[Andrew Haley]

On Tue, 11 May 2021 16:05:24 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

>> On x86_64 macOS the following sequence works just fine:
>> 
>> attempt_reserve_memory_at(executable=false)
>> commit_memory(executable=true)
>> 
>> however, on aarch64 macOS it fails.
>> 
>> We fix the test itself to explicitly ask for executable memory when reserving it since it later commits it as executable.
>
> Gerard Ziemski has updated the pull request incrementally with one additional commit since the last revision:
> 
>   do not expose memory with exec priviledges unless explicitly asked for, fix the test intead to ask for exececutable memory as needed

test/hotspot/gtest/runtime/test_os.cpp line 371:

> 369:   for (int stripe = 0; stripe < num_stripes; stripe++) {
> 370:     address q = p + (stripe * stripe_len);
> 371:     q = (address)os::attempt_reserve_memory_at((char*)q, stripe_len, true);

A comment here would hurt no one.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3865