RFR: 8266404: Fatal error report generated with -XX:+CrashOnOutOfMemoryError should not contain suggestion to submit a bug report [v2]

[Gerard Ziemski]

On Thu, 13 May 2021 08:06:24 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> A simple fix to add a new VMErrorType (OOM_JAVA_HEAP_FATAL) to indicate we've requested a Java OOM error to be fatal. A new overload of report_fatal is provided to allow this to be passed through.
>> 
>> VMError has an existing notion of "should_report_bug" but that encompasses more than just printing the bug submission URL, so I added a new specific check for that.
>> 
>> Checked hs_err files before and after with the fix, from the CrashOnOutOfMemoryError test.
>> 
>> Tested tiers 1-3 for good measure.
>> 
>> Thanks,
>> David
>
> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments from Thomas

Changes requested by gziemski (Committer).

src/hotspot/share/utilities/debug.cpp line 319:

> 317:   report_fatal_impl(INTERNAL_ERROR, file, line, detail_fmt, detail_args);
> 318:   va_end(detail_args);
> 319: }

Do we really need this API? Can't we just update:


#define fatal(...)                                                                \
do {                                                                              \
  TOUCH_ASSERT_POISON;                                                            \
  report_fatal(INTERNAL_ERROR, __FILE__, __LINE__, __VA_ARGS__);                                  \
  BREAKPOINT;                                                                     \
} while (0)

-------------

PR: https://git.openjdk.java.net/jdk/pull/4006