RFR: 8266404: Fatal error report generated with -XX:+CrashOnOutOfMemoryError should not contain suggestion to submit a bug report [v2]

[David Holmes]

On Fri, 14 May 2021 18:56:48 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

>> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments from Thomas
>
> src/hotspot/share/utilities/debug.cpp line 319:
> 
>> 317:   report_fatal_impl(INTERNAL_ERROR, file, line, detail_fmt, detail_args);
>> 318:   va_end(detail_args);
>> 319: }
> 
> Do we really need this API? Can't we just update:
> 
> 
> #define fatal(...)                                                                \
> do {                                                                              \
>   TOUCH_ASSERT_POISON;                                                            \
>   report_fatal(INTERNAL_ERROR, __FILE__, __LINE__, __VA_ARGS__);                                  \
>   BREAKPOINT;                                                                     \
> } while (0)

As the fatal() macro seems to be the only user of the existing `report_fatal` then yes I think we can simplify this as you suggest. I had thought it was used directly from elsewhere.

Thanks for the suggestion.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4006