RFR: 8267754: cds/appcds/loaderConstraints/LoaderConstraintsTest.java fails on x86_32 due to customized class loader is not supported [v2]
Igor Ignatyev
iignatyev at openjdk.java.net
Wed May 26 08:00:21 UTC 2021
On Wed, 26 May 2021 04:05:44 GMT, Jie Fu <jiefu at openjdk.org> wrote:
>> test/hotspot/jtreg/runtime/cds/appcds/loaderConstraints/LoaderConstraintsTest.java line 113:
>>
>>> 111: appJar = ClassFileInstaller.writeJar("loader_constraints.jar", appClasses);
>>> 112: doTest();
>>> 113: if (!Platform.isWindows() && Platform.is64bit()) {
>>
>> Platform.java has a function: Platform.areCustomLoadersSupportedForCDS(). You can use here.
>
>> Platform.java has a function: Platform.areCustomLoadersSupportedForCDS(). You can use here.
>
> Good suggestion!
> Updated.
> Thanks.
I think a better solution would be to split the test into two subtests (two separate jtreg test descriptions in one .java file): one for `doTest` another for `doTestCustomLoader` and use `@requires vm.cds.custom.loaders` in the 2nd one. this way, we will get more clear test results.
Cheers,
-- Igor
-------------
PR: https://git.openjdk.java.net/jdk/pull/4198
More information about the hotspot-runtime-dev
mailing list