RFR: 8252476: as_Worker_thread() doesn't check what it intends [v3]

[Ioi Lam]

On Thu, 27 May 2021 02:27:05 GMT, David Holmes <dholmes at openjdk.org> wrote:

> The update seems fine to me. But you need to check with @iklam whether including nonJavaThread.hpp in thread.inline.hpp negates the point of splitting out nonJavaThread.hpp in the first place.
> 

I think it's OK to include nonJavaThread.hpp in thread.inline.hpp (included by about 30% of hotspot .o files). But we should avoid including it in thread.hpp (included by about 80% of hotspot .o files)

BTW, we should make `JavaThread::as_CompilerThread` consistent as well: move to thread.inline.hpp, change the casting,  and rename to `as_Compiler_thread` (in another RFE??)

-------------

PR: https://git.openjdk.java.net/jdk/pull/4167