RFR: 8275775: VM.metaspace prints flag 'f' for classes that have non-trivial finalize() [v3]

[David Holmes]

On 2/11/2021 3:26 pm, Thomas Stuefe wrote:
> On Tue, 2 Nov 2021 00:14:48 GMT, David Holmes <dholmes at openjdk.org> wrote:
> 
>>> I like this (also the succinct name). Unfortunately, this would need a CSR, but if you have not yet done that we can help with this.
>>
>> @tstuefe We do not use CSR requests with jcmd changes as they are deemed diagnostic commands - ref JDK-8203682 :)
> 
> Seems odd since these are outside interfaces, used in scripts and whatnot. IMHO one of the places where CSR really makes sense.

 From [1]

David >  1. Have we previously established whether a CSR request is 
needed for a new Dcmd?

Thomas > "My feeling is no, since this adds a new command, so there can 
be no backward compat issues."

:)

[1] 
http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2018-May/028190.html

Everyone is entitled to change their mind of course, but new commands 
don't have compatibility issues as you point out. And diagnostic 
interfaces don't need to go through the CSR process. So ...

Cheers,
David

> -------------
> 
> PR: https://git.openjdk.java.net/jdk/pull/6075
>