RFR: 8275775: VM.metaspace prints flag 'f' for classes that have non-trivial finalize()

Thomas Stuefe stuefe at openjdk.java.net
Tue Nov 2 06:49:14 UTC 2021


On Tue, 2 Nov 2021 06:31:40 GMT, David Holmes <david.holmes at oracle.com> wrote:

> > > 
> > > 
> > > @tstuefe We do not use CSR requests with jcmd changes as they are deemed diagnostic commands - ref JDK-8203682 :)
> > 
> > 
> > Seems odd since these are outside interfaces, used in scripts and whatnot. IMHO one of the places where CSR really makes sense.
> 
> From [1]
> 
> David > 1. Have we previously established whether a CSR request is needed for a new Dcmd?
> 
> Thomas > "My feeling is no, since this adds a new command, so there can be no backward compat issues."
> 
> :)

Hah, that's embarrassing :-) 

I actually changed my mind with the asynchronous -Xlog discussions recently (https://bugs.openjdk.java.net/browse/JDK-8229517). CSR seemed to work well here, a good way to get more eyes for the user-facing command syntax. But I know that CSR is not the perfect process either (slow, arduous, and arguably new commands are not a backward compatibility issue).

-------------

PR: https://git.openjdk.java.net/jdk/pull/6075


More information about the hotspot-runtime-dev mailing list