RFR: 8276787: Improve warning messages for -XX:+RecordDynamicDumpInfo

[Calvin Cheung]

On Mon, 15 Nov 2021 23:57:13 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> src/hotspot/share/runtime/arguments.cpp line 3504:
>> 
>>> 3502:     }
>>> 3503:     check_unsupported_dumping_properties();
>>> 3504:     SharedDynamicArchivePath = os::strdup_check_oom(ArchiveClassesAtExit, mtArguments);
>> 
>> I think it is clearer to leave this assignment alone.
>> It works in your current patch because in line 3561, the `ArchiveClassesAtExit` is used instead of `SharedDynamicArchivePath`.
>
> SharedDynamicArchivePath had two meanings before this PR:
> 
> 1. the dynamic archive that will be mapped during VM start-up. 
> 2. the dynamic archive that will be dumped.
> 
> This made the code complicated (E.g., the old version of DynamicArchive::dump() needed to call into Arguments::init_shared_archive_paths() to set it SharedDynamicArchivePath).
> 
> This PR removed the second meaning. That's why I removed line 3504. Now if ArchiveClassesAtExit is specified, SharedDynamicArchivePath will be NULL.

Thanks for your explanation. It makes sense.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6383