RFR: 8276787: Improve warning messages for -XX:+RecordDynamicDumpInfo [v2]

Ioi Lam iklam at openjdk.java.net
Tue Nov 16 06:30:02 UTC 2021


> [1] Fixed the error messages for the three scenarios described in the bug report. See the test SharedArchiveFileOption.java for new test cases for these messages.
> 
> [2] The global SharedDynamicArchivePath was used for both reading and writing the dynamic archive. Now the writing part is handled by DynamicArchiveBuilder::_archive_name. This simplifies the logic in Arguments::init_shared_archive_paths() and DynamicArchive::dump_for_jcmd(). It also makes the checks in [1] easier to implement.
> 
> Testing: running through Oracle CI tiers 1-4.

Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:

  @calvinccheung comments

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/6383/files
  - new: https://git.openjdk.java.net/jdk/pull/6383/files/9f959ed6..346c1d9e

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=6383&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=6383&range=00-01

  Stats: 3 lines in 2 files changed: 1 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/6383.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/6383/head:pull/6383

PR: https://git.openjdk.java.net/jdk/pull/6383


More information about the hotspot-runtime-dev mailing list