RFR: 8273471: Add foldmultilines to UL for stdout/err [v5]
Yasumasa Suenaga
ysuenaga at openjdk.java.net
Fri Sep 10 08:41:04 UTC 2021
On Fri, 10 Sep 2021 05:01:23 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one additional commit since the last revision:
>>
>> output options for stdout/err should be applied just once
>
> src/hotspot/share/logging/logFileOutput.cpp line 461:
>
>> 459: void LogFileOutput::describe(outputStream *out) {
>> 460: LogFileStreamOutput::describe(out);
>> 461: out->print(",filecount=%u,filesize=" SIZE_FORMAT "%s,async=%s", _file_count,
>
> Don't we just need to add `foldMultilines` to this print statement? Or is it separate so that it applies to stdout/err as well?
`foldmultilines` is provided by `LogFileStreamOutput`, and it might provide more options in future. So I delegate statement printing to `LogFileStreamOutput`, then print options in `LogFileOutput`.
This change also applies to stdout/err log outputs.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5407
More information about the hotspot-runtime-dev
mailing list