RFR: 8273471: Add foldmultilines to UL for stdout/err [v5]

Yasumasa Suenaga ysuenaga at openjdk.java.net
Fri Sep 10 14:43:46 UTC 2021


On Fri, 10 Sep 2021 05:04:34 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Yasumasa Suenaga has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   output options for stdout/err should be applied just once
>
> src/hotspot/share/logging/logConfiguration.cpp line 419:
> 
>> 417:   if (output == NULL || strlen(output) == 0 ||
>> 418:       strcmp("stdout", output) == 0 || strcmp("#0", output) == 0) {
>> 419:     if (!stdout_configured) {
> 
> So you are piggy-backing on parse_log_arguments() to produce the warning ... can you add a comment at the end:
> // else - fall-through to normal option processing which will be rejected with a warning

I added it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5407


More information about the hotspot-runtime-dev mailing list