RFR: 8273471: Add foldmultilines to UL for stdout/err [v5]

David Holmes dholmes at openjdk.java.net
Sun Sep 12 22:20:49 UTC 2021


On Fri, 10 Sep 2021 14:40:51 GMT, Yasumasa Suenaga <ysuenaga at openjdk.org> wrote:

>> src/hotspot/share/logging/logConfiguration.cpp line 419:
>> 
>>> 417:   if (output == NULL || strlen(output) == 0 ||
>>> 418:       strcmp("stdout", output) == 0 || strcmp("#0", output) == 0) {
>>> 419:     if (!stdout_configured) {
>> 
>> So you are piggy-backing on parse_log_arguments() to produce the warning ... can you add a comment at the end:
>> // else - fall-through to normal option processing which will be rejected with a warning
>
> I added it.

You added it in the wrong place - it is supposed to document the not-present "else" part of "if (!stdout_configured) {"

-------------

PR: https://git.openjdk.java.net/jdk/pull/5407


More information about the hotspot-runtime-dev mailing list