RFR: 8271569: Clean up the use of CDS constants and field offsets [v3]

Yumin Qi minqi at openjdk.java.net
Tue Sep 14 03:16:05 UTC 2021


On Tue, 14 Sep 2021 00:50:13 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Yumin Qi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Rollled back _base_region_crc to private, changed CDSConst's value from type int to size_t
>
> src/hotspot/share/cds/cdsConstants.hpp line 37:
> 
>> 35:  public:
>> 36:   static CDSConst offsets[];
>> 37:   static CDSConst constants[];
> 
> Why are these public?

Should be private, thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5450


More information about the hotspot-runtime-dev mailing list