RFR: 8271569: Clean up the use of CDS constants and field offsets [v4]

David Holmes dholmes at openjdk.java.net
Tue Sep 14 04:22:05 UTC 2021


On Mon, 13 Sep 2021 13:33:19 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Yumin Qi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   offsets and constants should be private
>
> src/hotspot/share/cds/cdsConstants.cpp line 26:
> 
>> 24: 
>> 25: #include "precompiled.hpp"
>> 26: #include <cstddef>
> 
> It is not stated in the style guide, but I think most files include the system headers after the HotSpot headers, separated by a blank line.

Is this even needed now? I don't see it being used.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5450


More information about the hotspot-runtime-dev mailing list