RFR: JDK-8284758: [linux] improve print_container_info [v2]

Lutz Schmidt lucy at openjdk.java.net
Thu Apr 14 08:11:09 UTC 2022


On Wed, 13 Apr 2022 17:57:06 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> :) yes, just noticed. Sorry. Something in the kernel seems to page-align those user values, but I don't know if that's guaranteed. Anyhow `< 1k` is fine with me too.
>
> I leave it up to Matthias...

So many comments about formatting - so I dare to add mine as well:

- We have these nice global declarations (K = 1024, M = K*K, ...). Why not use these?
- I like small sizes being displayed as "< 1k"
- How about displaying sizes < 10M as k, < 10G as M, and so forth?
 
These comments are no blockers. It's up to Matthias to honour them.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8217


More information about the hotspot-runtime-dev mailing list