RFR: JDK-8284758: [linux] improve print_container_info [v2]
Matthias Baesken
mbaesken at openjdk.java.net
Thu Apr 14 10:35:15 UTC 2022
On Thu, 14 Apr 2022 08:05:28 GMT, Lutz Schmidt <lucy at openjdk.org> wrote:
>> I leave it up to Matthias...
>
> So many comments about formatting - so I dare to add mine as well:
>
> - We have these nice global declarations (K = 1024, M = K*K, ...). Why not use these?
> - I like small sizes being displayed as "< 1k"
> - How about displaying sizes < 10M as k, < 10G as M, and so forth?
>
> These comments are no blockers. It's up to Matthias to honour them.
Hello, I adjusted the output of small values following Severins suggestion.
Regarding having k and M , this might be a good idea but in the "S Y S T E M" part of hs_err/hs_info we use k/kB and no M and I wanted to be consistent with most other current output.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8217
More information about the hotspot-runtime-dev
mailing list