RFR: JDK-8285362: unify os::pause platform coding

Lutz Schmidt lucy at openjdk.java.net
Fri Apr 22 08:18:25 UTC 2022


On Thu, 21 Apr 2022 12:30:34 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> The os::pause() coding in the different os_platform.cpp files is very close, so it should be unified at os.cpp .
> Small differences : Windows uses Sleep, the other platforms use poll.
> AIX used trcVerbose for some error/warning - like  output, the other platforms used jio_fprintf ; I think it makes sense to unify this on all OS to jio_fprintf .

Changes look good to me.
I like it when quasi-identical code is consolidated into one place. Redundancy s...

-------------

Marked as reviewed by lucy (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8338


More information about the hotspot-runtime-dev mailing list