RFR: 8292590: Product JVM crashes with FLAG_SET_XXX on non-product Flag

[Ioi Lam]

On Mon, 29 Aug 2022 23:38:16 GMT, David Holmes <dholmes at openjdk.org> wrote:

> Hardly trivial as these macros are totally obscure to begin with :)

OK I removed the word "trivial" from the PR descroption.

> Where is the definition of what the arguments to ALL_FLAGS means? [Found it - allFlags.hpp]
> 
> It appears we have been handling develop and notproduct incorrectly. Doesn't JVMFlagsEnum also need adjustment?

Yes, `notproduct` is not handled correctly. See [JDK-8293045l](https://bugs.openjdk.org/browse/JDK-8293045l), due to which JVMFlagsEnum cannot be adjusted in this PR. That would need to be done as a part of JDK-8293045l.

-------------

PR: https://git.openjdk.org/jdk/pull/10072