RFR: 8293046: Move CDS command-line flags to cds_globals.hpp [v2]

[Ioi Lam]

On Tue, 30 Aug 2022 01:33:24 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Are you saying that none of the CDS flags are already actually gated on INCLUDE_CDS?
>> 
>> But good point about putting the guard inside the cds_globals.hpp file - obvious :)
>
> Unfortunately there are a few references to the CDS flags like SharedBaseAddress that are not gated.
> 
> This PR makes it easy to detect such cases (by adding an empty CDS_FLAGS macro in cds_globals.hpp if INCLUDE_CDS is false). I think such cleanup can be done in a follow-up PR.

I filed https://bugs.openjdk.org/browse/JDK-8293135 to deal with such use of the CDS flags when CDS is disabled. There are potential compatibility issues, so we need some more discussion before proceeding.

-------------

PR: https://git.openjdk.org/jdk/pull/10073