RFR: 8293046: Move CDS command-line flags to cds_globals.hpp [v2]

David Holmes dholmes at openjdk.org
Wed Aug 31 05:47:12 UTC 2022


On Tue, 30 Aug 2022 21:47:19 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Unfortunately there are a few references to the CDS flags like SharedBaseAddress that are not gated.
>> 
>> This PR makes it easy to detect such cases (by adding an empty CDS_FLAGS macro in cds_globals.hpp if INCLUDE_CDS is false). I think such cleanup can be done in a follow-up PR.
>
> I filed https://bugs.openjdk.org/browse/JDK-8293135 to deal with such use of the CDS flags when CDS is disabled. There are potential compatibility issues, so we need some more discussion before proceeding.

Okay. Thanks

-------------

PR: https://git.openjdk.org/jdk/pull/10073


More information about the hotspot-runtime-dev mailing list