RFR: 8281822: Test failures on non-DTrace builds due to incomplete DTrace* flags handling [v3]

[Aleksey Shipilev]

On Wed, 16 Feb 2022 07:36:40 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Test fixes
>
> src/hotspot/share/runtime/arguments.cpp line 2911:
> 
>> 2909:     } else if (match_option(option, "-XX:+DTraceMethodProbes")) {
>> 2910:       jio_fprintf(defaultStream::error_stream(),
>> 2911:                   "DTraceMethodProbes flag is not applicable for this configuration\n");
> 
> Looking at this again, in light of the test changes, I have to wonder if the pre-existing treatment of `ExtendedDTraceProbes` was wrong and we should simply have used `UNSUPPORTED_OPTION` in these cases?

Maybe, but this block also handles ergonomic opt-in to `DTrace*` flags when `ExtendedDTraceProbe` is enabled, and it matches the style of the similar checks. I'd leave it as is.

> test/hotspot/jtreg/compiler/runtime/Test8168712.java line 27:
> 
>> 25:  * @test
>> 26:  * @requires vm.debug
>> 27:  * @requires vm.hasDTrace
> 
> DTrace is not critical to this test. IIUC the original fix and test had an issue when combined with DTrace hence the test enabled it to check it was fixed by a further patch. So we actually want to run this test regardless. In which case we need to add another test section for when `!vm.hasDTrace` that doesn't pass the DTrace flag.

Right. Added, see new commit.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7477