RFR: 8281822: Test failures on non-DTrace builds due to incomplete DTrace* flags handling [v3]

David Holmes dholmes at openjdk.java.net
Wed Feb 16 08:08:05 UTC 2022


On Wed, 16 Feb 2022 08:00:19 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> src/hotspot/share/runtime/arguments.cpp line 2911:
>> 
>>> 2909:     } else if (match_option(option, "-XX:+DTraceMethodProbes")) {
>>> 2910:       jio_fprintf(defaultStream::error_stream(),
>>> 2911:                   "DTraceMethodProbes flag is not applicable for this configuration\n");
>> 
>> Looking at this again, in light of the test changes, I have to wonder if the pre-existing treatment of `ExtendedDTraceProbes` was wrong and we should simply have used `UNSUPPORTED_OPTION` in these cases?
>
> Maybe, but this block also handles ergonomic opt-in to `DTrace*` flags when `ExtendedDTraceProbe` is enabled, and it matches the style of the similar checks. I'd leave it as is.

ok

-------------

PR: https://git.openjdk.java.net/jdk/pull/7477


More information about the hotspot-runtime-dev mailing list