RFR: 8281543: Remove unused code/headerfile dtraceAttacher.hpp

Emanuel Peter duke at openjdk.java.net
Tue Feb 22 07:32:46 UTC 2022


On Sun, 20 Feb 2022 22:11:06 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> `dtraceAttacher.cpp` with all the relevant definitions was deleted [here](https://github.com/openjdk/jdk/commit/071bd521bca2485c6df95c45e4310d39b05bd046)
>> in connection with [JDK-8244224](https://bugs.openjdk.java.net/browse/JDK-8244224) (Remove the Solaris and SPARC Ports).
>> 
>> I deleted `dtraceAttacher.cpp`, and the 4 include statements of it in 4 `src/hotspot/os/???/attachListener_???.cpp` files.
>> 
>> Ran tests, mostly to check that it still compiles on various platforms.
>
> Hi Emanuel,
> 
> This looks good and trivial.
> 
> AFAICS the existence of these includes was a mistake in the first place. Only `attachListener_solaris.cpp` actually needed it, but a limitation of the ancient `includeDB` mechanism meant it was listed as needed by all `attachListener_<os_family>.cpp` files. Then when we got rid of `includeDB` and moved to the standard include mechanism, that dependency was expanded to produce an include entry in each file now being fixed.
> 
> Cheers,
> David

Thanks @dholmes-ora @TobiHartmann for the reviews!

-------------

PR: https://git.openjdk.java.net/jdk/pull/7544


More information about the hotspot-runtime-dev mailing list