Integrated: 8267341: macos attempt_reserve_memory_at(arg1, arg2, true) failure
Gerard Ziemski
gziemski at openjdk.java.net
Wed Jan 19 22:38:50 UTC 2022
On Tue, 4 Jan 2022 19:18:45 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:
> Re-enable **release_multi_mappings** gtest on macOS
>
> This test would occasionally fail on macOS, but thanks to Dan's catch, it turned out that it actually only fails on those test machines that run macOS 10.13.6 or earlier.
>
> The proposed fix simply makes a single call to `os::reserve_memory()` with the `executable` flag `True`, and if that failed forces `executable` to `False` later in the actual test code (alternatively we could have just also skipped that test portion completely, but this way we actually do something rather than nothing at all).
>
> Tested manually on macOS 10.13.6 and via Mach5
This pull request has now been integrated.
Changeset: d1efb0cc
Author: Gerard Ziemski <gziemski at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/d1efb0cc56127a40f2b23ccc608b27be2b39a389
Stats: 32 lines in 1 file changed: 28 ins; 4 del; 0 mod
8267341: macos attempt_reserve_memory_at(arg1, arg2, true) failure
Reviewed-by: dcubed, dholmes
-------------
PR: https://git.openjdk.java.net/jdk/pull/6960
More information about the hotspot-runtime-dev
mailing list