RFR: 8290739: Simplify storage of dump-time class information [v3]
Calvin Cheung
ccheung at openjdk.org
Wed Jul 27 17:17:55 UTC 2022
On Tue, 26 Jul 2022 23:08:11 GMT, Ioi Lam <iklam at openjdk.org> wrote:
>> Some code clean up in anticipation of future CDS development.
>>
>> I moved the initialization of `SystemDictionaryShared::_dumptime_table` and `SystemDictionaryShared::_dumptime_lambda_proxy_class_dictionary` to VM bootstrap, so that:
>> - We don't need to allocate these tables dynamically
>> - We don't need to check if these tables exist when writing the archive
>>
>> The current implementation guarantees that `SystemDictionaryShared::_dumptime_table` always contains a `DumpTimeClassInfo` for each `InstanceKlass` that's being considered for inclusion in the CDS archive. I simplified the old `SystemDictionaryShared::find_or_allocate_info_for()` API to
>>
>>
>> // Guaranteed to return non-NULL value for non-shared classes.
>> // k must not be a shared class.
>> DumpTimeClassInfo* SystemDictionaryShared::get_info(InstanceKlass* k)
>>
>>
>> For more details, please see JBS issue: [JDK-8290739](https://bugs.openjdk.org/browse/JDK-8290739)
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>
> fixed whitespaces
Updates look good.
-------------
Marked as reviewed by ccheung (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9634
More information about the hotspot-runtime-dev
mailing list