RFR: 8287854: Dangling reference in ClassVerifier::verify_class

[Ioi Lam]

On Wed, 8 Jun 2022 04:26:07 GMT, David Holmes <dholmes at openjdk.org> wrote:

> The change is functionally correct, but this seems like a textbook case for a RAII helper class.

I agree with David that RAII is needed here. There's one exit path that's not covered by the existing patch:


void ClassVerifier::verify_class(TRAPS) {
   ...
   verify_method(methodHandle(THREAD, m), CHECK_VERIFY(this));
   ...
}

-------------

PR: https://git.openjdk.java.net/jdk/pull/9075