RFR: 8288443: Simplify vmClasses::resolve_all()

David Holmes dholmes at openjdk.java.net
Wed Jun 15 13:00:00 UTC 2022


On Tue, 14 Jun 2022 17:54:25 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> Please review this simple clean up:
> 
> - There's no need to initialize the JSR 292 classes separately (the `-XX:+EnableInvokeDynamic` option has been removed long time ago).
> - Separate initialization of the reference classes is not necessary when CDS is enabled.

Seems fine.

There are related comments about ordering and 1.4 JDKs in vmClassMacros.hpp that should also be cleaned up. I find it interesting it says

 /* Note: MethodHandle must be first, and VolatileCallSite last in group */ 

when DirectMethodHandle is actually first.

Thanks.

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9157


More information about the hotspot-runtime-dev mailing list