RFR: 8288443: Simplify vmClasses::resolve_all() [v2]

Ioi Lam iklam at openjdk.java.net
Wed Jun 15 16:26:37 UTC 2022


On Wed, 15 Jun 2022 12:56:31 GMT, David Holmes <dholmes at openjdk.org> wrote:

> Seems fine.
> 
> There are related comments about ordering and 1.4 JDKs in vmClassMacros.hpp that should also be cleaned up. I find it interesting it says
> 
> /* Note: MethodHandle must be first, and VolatileCallSite last in group */
> 
> when DirectMethodHandle is actually first.
> 
> Thanks.

I removed the out-dated comments about supporting earlier JDKs. Also removed the info about the ordering of the `MethodHandle` classes. I have no idea whether or why the ordering is important, but this mystery should be covered by the comment about the `VM_CLASSES_DO` macro definition.


// The order of these definitions is significant: the classes are
// resolved by vmClasses::resolve_all() in this order. Changing the
// order may require careful restructuring of the VM start-up sequence.

-------------

PR: https://git.openjdk.org/jdk/pull/9157


More information about the hotspot-runtime-dev mailing list