RFR: 8280235: Deprecated flag FlightRecorder missing from VMDeprecatedOptions test [v2]

[David Holmes]

On Fri, 17 Jun 2022 06:51:51 GMT, KIRIYAMA Takuya <duke at openjdk.org> wrote:

>> I would like to fix 8280235: Deprecated flag FlightRecorder missing from VMDeprecatedOptions test. 
>> 
>> FlightRecorder option has not been tested since JDK13.
>> I think we should test it, because FlightRecorder option has not been obsolete in the latest JDK.
>> Users would be in trouble if the option suddenly disappears without notice, 
>> so it's important to confirm the deprication message.
>> 
>> Also we should add a test of ExtendedDTraceProbes option.
>> The test was disabled in 8281675, because some jdk can't specify it.
>> I modified the test to be able to verify  ExtendedDTraceProbes in either case that DTRACE_ENABLED is enabled or not.
>
> KIRIYAMA Takuya has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8280235: Deprecated flag FlightRecorder missing from VMDeprecatedOptions test

Changes requested by dholmes (Reviewer).

test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java line 103:

> 101:             String match = getDeprecationString(jfrOptionNames[0]);
> 102:             output.shouldMatch(match);
> 103:         }

This is not the way to handle this. In the static block that initializes the set of flags to test you should do something like:


if (wb.isJFRIncluded()) {
  deprecated.add("FlightRecorder", false);
}

before line 70.

-------------

PR: https://git.openjdk.org/jdk/pull/9123