RFR: 8280235: Deprecated flag FlightRecorder missing from VMDeprecatedOptions test [v2]

KIRIYAMA Takuya duke at openjdk.org
Wed Jun 22 06:50:42 UTC 2022


On Mon, 20 Jun 2022 00:07:07 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> KIRIYAMA Takuya has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8280235: Deprecated flag FlightRecorder missing from VMDeprecatedOptions test
>
> test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java line 103:
> 
>> 101:             String match = getDeprecationString(jfrOptionNames[0]);
>> 102:             output.shouldMatch(match);
>> 103:         }
> 
> This is not the way to handle this. In the static block that initializes the set of flags to test you should do something like:
> 
> 
> if (wb.isJFRIncluded()) {
>   deprecated.add("FlightRecorder", false);
> }
> 
> before line 70.

Thank you for your comment. 
I fixed the test. Could you please review it again?

-------------

PR: https://git.openjdk.org/jdk/pull/9123


More information about the hotspot-runtime-dev mailing list