RFR: JDK-8282593: JDK-8281472 breaks 32-bit builds and gtests
David Holmes
dholmes at openjdk.java.net
Thu Mar 3 12:38:57 UTC 2022
On Thu, 3 Mar 2022 09:54:48 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
> Hi, may I please have reviews for this trivial fix.
>
> JDK-8281472 added a test_largeOptions.cpp gtest. Parts of it don't build for 32-bits, parts build but don't run.
>
> I propose to exclude the failing parts. AFAICS they check that numerical arguments are handled correctly when going beyond INT_MAX and INT_MIN, which is not an issue on 32-bit with 32-bit ints.
>
> Thanks, Thomas
This seems expedient to fix the build failure.
Thanks,
David
Hi Thomas,
This is a duplicate of JDK-8282513. I fixed the actual build problem but then discovered the test was failing. Excluding it from 32-bit may be the better solution as I don't have time to try and figure out what is wrong with the test.
David
-------------
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/7672
More information about the hotspot-runtime-dev
mailing list