RFR: 8283784: java_lang_String::as_platform_dependent_str stores to oop in native state

Aleksey Shipilev shade at openjdk.java.net
Wed Mar 30 08:05:36 UTC 2022


On Wed, 30 Mar 2022 05:32:14 GMT, David Holmes <dholmes at openjdk.org> wrote:

> Please review this trivial fix that adjusts the block scope so that JNIHandles::destroy_local is called once we are back in VM, and so no longer safepoint-safe.
> 
> Testing: tiers 1-3 as sanity test
> 
> Thanks,
> David

All right! 

Speaking of that verification code, would it be upstreamed separately? Otherwise it looks like we should really assert the correct state in `JNIHandles::destroy_local` to catch these problems.

-------------

Marked as reviewed by shade (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8031


More information about the hotspot-runtime-dev mailing list