RFR: 8283784: java_lang_String::as_platform_dependent_str stores to oop in native state

David Holmes dholmes at openjdk.java.net
Wed Mar 30 09:36:36 UTC 2022


On Wed, 30 Mar 2022 07:28:44 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Please review this trivial fix that adjusts the block scope so that JNIHandles::destroy_local is called once we are back in VM, and so no longer safepoint-safe.
>> 
>> Testing: tiers 1-3 as sanity test
>> 
>> Thanks,
>> David
>
> Looks good.  Not sure I'd describe this as "trivial", but maybe I've just forgotten too much about JNI local handle management, so it required some time to page that back in.

Thanks for the reviews @kimbarrett  and @shipilev .

I do hope/expect the verification code, in some form, to be integrated as well in the near future.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8031


More information about the hotspot-runtime-dev mailing list