RFR: 8285832: runtime/Thread/TooSmallStackSize.java failed "assert(k->is_initialized()) failed: need to increase java_thread_min_stack_allowed calculation" [v3]

[Coleen Phillimore]

On Tue, 3 May 2022 00:59:31 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add global os_min_stack_allowed.
>
> src/hotspot/os/windows/os_windows.cpp line 4288:
> 
>> 4286: 
>> 4287:   // Check and sets minimum stack sizes against command line options
>> 4288:   if (set_minimum_stack_sizes(_plaform_minimum_stack_allowed) == JNI_ERR) {
> 
> typo: should be `_os_min_stack_allowed`

This was temporarily broken, fixed now.

> test/hotspot/jtreg/runtime/Thread/TooSmallStackSize.java line 96:
> 
>> 94: 
>> 95:     static ProcessBuilder createProcessWithOptions(String stackOption, String stackSize) throws Exception {
>> 96:         if (testShadowSize == null) {
> 
> There would be far less duplication if you just used:
> 
> `testShadowSize == null ? "" : ("-XX:StackShadowPages=" + testShadowSize)`

Ok, sure.  I'll see if it compiles.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8471