RFR: 8285832: runtime/Thread/TooSmallStackSize.java failed "assert(k->is_initialized()) failed: need to increase java_thread_min_stack_allowed calculation" [v3]

[Coleen Phillimore]

On Tue, 3 May 2022 11:50:09 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/os/windows/os_windows.cpp line 4288:
>> 
>>> 4286: 
>>> 4287:   // Check and sets minimum stack sizes against command line options
>>> 4288:   if (set_minimum_stack_sizes(_plaform_minimum_stack_allowed) == JNI_ERR) {
>> 
>> typo: should be `_os_min_stack_allowed`
>
> This was temporarily broken, fixed now.

Good catch. I forgot to push the fix.  Now pushed.

>> test/hotspot/jtreg/runtime/Thread/TooSmallStackSize.java line 96:
>> 
>>> 94: 
>>> 95:     static ProcessBuilder createProcessWithOptions(String stackOption, String stackSize) throws Exception {
>>> 96:         if (testShadowSize == null) {
>> 
>> There would be far less duplication if you just used:
>> 
>> `testShadowSize == null ? "" : ("-XX:StackShadowPages=" + testShadowSize)`
>
> Ok, sure.  I'll see if it compiles.

The process builder doesn't like the "" argument and thinks it's the class name.  There's 3 lines of duplication plus a 3 line comment.  That's why I put it together in a function.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8471