RFR: 8287512: continuationEntry.hpp has incomplete definitions

[Ron Pressler]

On Mon, 30 May 2022 12:15:03 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Please review this small change, which cleans up continuationEntry.hpp and fixes incomplete definitions.
>> 
>> Passes tier1
>
> src/hotspot/share/runtime/continuationEntry.cpp line 38:
> 
>> 36: address ContinuationEntry::return_pc = nullptr;
>> 37: 
>> 38: void ContinuationEntry::set_enter_nmethod(CompiledMethod* cm) {
> 
> This looks weird. Do we really have `CompiledMethod*` arguments for this call? If so, it would be weird to call it `set_enter_*nmethod*`.

`CompiledMethod` is all that's required here, and I also want to try calling that method from elsewhere (Method::set_code) where we only have `CompiledMethod`. But if it bothers anyone I can leave it an nmethod.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8944