RFR: 8287512: continuationEntry.hpp has incomplete definitions [v2]
Ron Pressler
rpressler at openjdk.java.net
Tue May 31 15:33:27 UTC 2022
On Tue, 31 May 2022 11:49:13 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> `CompiledMethod` is all that's required here, and I also want to try calling that method from elsewhere (Method::set_code) where we only have `CompiledMethod`. But if it bothers anyone I can leave it an nmethod.
>
> I agree, maybe rename to set_enter_method or set_enter_code() ?
> Also the static data members don't have underscores, so I had to look to see what return_pc is, ie what this function did. Was there a reason? If not, please add leading underscores to these nonstatic data members.
Done
-------------
PR: https://git.openjdk.java.net/jdk/pull/8944
More information about the hotspot-runtime-dev
mailing list