RFR: 8295099: vmTestbase/nsk/stress/strace/strace013.java failed with "TestFailure: wrong lengths of stack traces: strace013Thread0: NNN strace013Thread83: MMM" [v2]
Leonid Mesnik
lmesnik at openjdk.org
Wed Nov 9 01:55:27 UTC 2022
On Mon, 7 Nov 2022 22:41:31 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> The test is incorrectly synchronized and may take the stack trace of a thread before it has entered the wait() and thus be three frames short of the correct stack. So I cleaned that up to ensure things are correctly synchronized.
>>
>> A number of comments in the test description etc were wrong so I also fixed those.
>>
>> These tests are stylistically awful but I refrained from embarking on a major cleanup and adopted the prevailing styles.
>>
>> Testing: local plus 50x on each platform (in progress)
>>
>> Thanks.
>
> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix comment typos.
> Remove "k-2" slack now that we are more precise.
The fix looks good. However, there is the same problem in other strace tests. They should be fixed also, new bug filed to fix them.
-------------
PR: https://git.openjdk.org/jdk/pull/11011
More information about the hotspot-runtime-dev
mailing list