RFR: 8297168: Provide a bulk OopHandle release mechanism with the ServiceThread [v3]

Daniel D. Daugherty dcubed at openjdk.org
Tue Nov 22 22:11:21 UTC 2022


On Tue, 22 Nov 2022 02:41:01 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> src/hotspot/share/runtime/javaThread.hpp line 85:
>> 
>>> 83:   friend class Continuation;
>>> 84:   friend class Threads;
>>> 85:   friend class ServiceThread; // for deferred OopHandle release access
>> 
>> Does this still have to be a friend?  You could make the two functions that ServiceThread calls public.
>
> I made them private and kept ServiceThread a friend so that it was more clear that this is a private interface with the ServiceThread and not some public API that might be called from other code.

Thanks for doing it via a 'friend' and including a comment.

-------------

PR: https://git.openjdk.org/jdk/pull/11254


More information about the hotspot-runtime-dev mailing list