RFR: 8294623: gtests does not work with googletest release-1.12.0+
David Holmes
dholmes at openjdk.org
Mon Oct 10 21:43:33 UTC 2022
On Mon, 10 Oct 2022 06:36:03 GMT, Dingli Zhang <dzhang at openjdk.org> wrote:
>> @dholmes-ora @tstuefe Hi, could anyone please help to take a look at this PR? Thanks in advance for your time!
>
>> @DingliZhang I've asked if anyone is familiar enough with googletest to review this, as I am not familiar with it.
>
> Hi @dholmes-ora, thank you for your help!
@DingliZhang According to the building.md documentation:
The supported version of Google Test is 1.8.1, whose source code can be obtained:
* by downloading and unpacking the source bundle from [here](https://github.com/google/googletest/releases/tag/release-1.8.1)
* or by checking out `release-1.8.1` tag of `googletest` project: `git clone -b release-1.8.1 https://github.com/google/googletest`
I don't know how old version 1.8.1 is or whether we need to expand on the supported releases here. Maybe the build folk will have an opinion? @magicus or @erikj79 .
-------------
PR: https://git.openjdk.org/jdk/pull/10503
More information about the hotspot-runtime-dev
mailing list