RFR: 8294623: gtests does not work with googletest release-1.12.0+

[Magnus Ihse Bursie]

On Fri, 30 Sep 2022 08:38:29 GMT, Dingli Zhang <dzhang at openjdk.org> wrote:

> The scope of `GTEST_DECLARE_string_(internal_run_death_test)` has been changed in googletest 1.12.0 [1]. So we can see some new compiler errors as below:
> 
> 
> $ bash configure --with-gtest=/home/dingli/jdk-tools/googletest && make run-test TEST="gtest:all"
> 
> * For target hotspot_variant-server_libjvm_gtest_objs_gtestMain.o:
> In file included from /home/dingli/jdk-tools/googletest/googlemock/include/gmock/internal/gmock-port.h:57,
>                  from /home/dingli/jdk-tools/googletest/googlemock/include/gmock/internal/gmock-internal-utils.h:49,
>                  from /home/dingli/jdk-tools/googletest/googlemock/include/gmock/gmock-actions.h:145,
>                  from /home/dingli/jdk-tools/googletest/googlemock/include/gmock/gmock.h:56,
>                  from /home/dingli/jdk/test/hotspot/gtest/unittest.hpp:51,
>                  from /home/dingli/jdk/test/hotspot/gtest/gtestMain.cpp:39:

We only support a specific version of gtest. The `building.md` file clearly states:


The supported version of Google Test is 1.8.1


I fully agree with you @kimbarrett. There is no need to support multiple versions of gtest. If 1.8.1 is old, we might consider upgrading, but that is a different discussion. I recommend closing this PR.

-------------

PR: https://git.openjdk.org/jdk/pull/10503